Use Py_XDECREF for pytopic_names_and_types. #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we got here through PyList_New failing, then pytopic_names_and_types could be NULL. Therefore, we need to use Py_XDECREF to handle the situation. Pointed out by clang static analysis. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
claireyywang
approved these changes
Nov 11, 2020
|
CI:
|
|
The warnings on Windows are being addressed by ros2/rcutils#311 , so they aren't caused by this PR. Thanks for the review, going ahead and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we got here through PyList_New failing, then pytopic_names_and_types
could be NULL. Therefore, we need to use Py_XDECREF to handle
the situation. Pointed out by clang static analysis.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org