Update spin_until_complete #919
Open
+239
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to changes in |
hliberacki
force-pushed
the
hliberacki/spin_until
branch
2 times, most recently
from
5c75743
to
09fc152
Compare
fujitatomoya
reviewed
Apr 1, 2022
hliberacki
force-pushed
the
hliberacki/spin_until
branch
2 times, most recently
from
be9cf5d
to
cf96887
Compare
|
ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together. |
wjwwood
requested changes
Jun 24, 2022
There was a problem hiding this comment.
This has some necessary changes. I think it can be decoupled from the ros2/rclcpp#1874 pr.
This was referenced Jun 24, 2022
…_for method * Deprecate spin_until_future_complete * Add spin_until_complete * Add spin_for method * Udpdate unit tests Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
…t tests Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
9b964fa
to
fabd752
Compare
* Deprecate old methods * fix comments Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
|
Now that #959 is merged this PR should update |
fujitatomoya
approved these changes
Jan 23, 2023
|
I've opened #1268 to replace this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in rclcpp replace spin_until_future_complete with spin_until_complete, add spin.
Signed-off-by: Hubert Liberacki hliberacki@gmail.com