Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All logging to the same stream #196

Merged
merged 11 commits into from
Feb 28, 2020
Merged

All logging to the same stream #196

merged 11 commits into from
Feb 28, 2020

Commits on Feb 21, 2020

  1. Always log on stderr 

    This follows the convention for human-readable diagnostic output on Linux systems.

fix #168

Make the stream configurable.

We default the stream to stderr, but allow the user to change
it to stdout by setting RCUTILS_CONSOLE_LINE_BUFFERED to 1.

Signed-off-by: Dan Rose <dan@digilabs.io>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @rotu @clalancette
    rotu authored and clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    3b827c9 View commit details
    Browse the repository at this point in the history

  2. Allow the user to specify buffering mode of stream. 

    And switch to using 'setvbuf', which allows us to get rid
of flush semantic during runtime.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    1125b4b View commit details
    Browse the repository at this point in the history

  3. Add in backwards compatibility message. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    35cfd09 View commit details
    Browse the repository at this point in the history

  4. More fixes from review. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    a220086 View commit details
    Browse the repository at this point in the history

  5. Add an rcutils_safe_strerror function. 

    Used in the logging stuff, and elsewhere in the codebase.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    5f0b914 View commit details
    Browse the repository at this point in the history

  6. Add in doxygen comments. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    e2d079d View commit details
    Browse the repository at this point in the history

  7. Fix symbol visibility for Windows. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    579ab72 View commit details
    Browse the repository at this point in the history

  8. Fixes from review. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    51562b5 View commit details
    Browse the repository at this point in the history

  9. More fixes from review. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    8abac20 View commit details
    Browse the repository at this point in the history

  10. One more fix from review. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    f21e226 View commit details
    Browse the repository at this point in the history

  11. Switch rcutils_safe_strerror -> rcutils_strerror 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    23df993 View commit details
    Browse the repository at this point in the history