Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify implementations to use one Participant per Context #183

Closed
6 tasks done
ivanpauno opened this issue Sep 3, 2019 · 4 comments
Closed
6 tasks done

Modify implementations to use one Participant per Context #183

ivanpauno opened this issue Sep 3, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ivanpauno
Copy link
Member

ivanpauno commented Sep 3, 2019

Feature request

Feature description

Design document here.
The idea is to implement everything in the rmw layer, and avoid changes in upstream layers as much as possible.

Tasks already done:

  • Port rmw_fastrtps.
  • Create common package rmw_dds_common, to allow easiest porting of remaining rmw implementations.
  • Disable failing cross vendor tests (@ivanpauno)
  • (security) Update sros2 and test_security.

To do:

  • Migrate rmw_connext (not needed, we changed to rmw_connextdds which is one-participant-per-context)
  • Migrate rmw_cyclonedds
@ivanpauno ivanpauno self-assigned this Sep 3, 2019
@ivanpauno ivanpauno added the enhancement New feature or request label Sep 3, 2019
@ivanpauno ivanpauno added this to To do in Eloquent via automation Sep 3, 2019
@ivanpauno
Copy link
Member Author

@hidmic @dirk-thomas @wjwwood FYI

@ivanpauno
Copy link
Member Author

ivanpauno commented Dec 18, 2019

Linked PRs:
rmw_fastrtps: ros2/rmw_fastrtps#312
rmw: #189
rmw_implementation: ros2/rmw_implementation#77
rcl: ros2/rcl#515
rmw_dds_common (new package): ros2/rmw_dds_common#4
rmw_cyclonedds API update: ros2/rmw_cyclonedds#106
rmw_connext API update: ros2/rmw_connext#392

@ivanpauno
Copy link
Member Author

I've updated the ticket with more up to date information.

@clalancette
Copy link
Contributor

I'm fairly sure this is done now. At least, I know for sure that it is fixed in Fast-DDS and Connext. I'm also fairly certain this is the case for Cyclone DDS. @eboasson @ivanpauno Please feel free to reopen if I'm wrong about Cyclone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Galactic
  
Done
Development

No branches or pull requests

2 participants