Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rmw_*_event_init() functions to rmw_implementation #202

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

mm318
Copy link
Member

@mm318 mm318 commented Mar 17, 2020

Related to ros2/ros2#822

This moves the rmw_publisher_event_init() and rmw_subscription_event_init() functions into rmw_implementation so that they will be able to check for whether or not the given type of rmw_event_type_t is supported by the chosen middleware.

Signed-off-by: Miaofei <miaofei@amazon.com>
…ation

Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318
Copy link
Member Author

mm318 commented Mar 18, 2020

@ivanpauno and @wjwwood, can we kick off CI and see if these changes are ready to be merged?

@ivanpauno
Copy link
Member

ivanpauno commented Mar 18, 2020

@ivanpauno and @wjwwood, can we kick off CI and see if these changes are ready to be merged?

Sure thing (try to provide a gist for this cases):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mm318
Copy link
Member Author

mm318 commented Mar 18, 2020

Sure thing (try to provide a gist for this cases):

Sorry! Will do next time!

@mm318
Copy link
Member Author

mm318 commented Mar 19, 2020

Does it look like we can merge this set of pull requests?

@ivanpauno
Copy link
Member

ivanpauno commented Mar 19, 2020

I will rerun linux CI job that failed randomly:

  • Linux Build Status

Most of the failures in Windows should been fixed after ros2/launch#391, the others seem random flaky tests failing. Re-running to check:

  • Windows Build Status (unrelated failures)

@mm318
Copy link
Member Author

mm318 commented Mar 19, 2020

@ivanpauno, it looks like the Linux build randomly failed again. Also, the test failures on Windows look unrelated.

@ivanpauno ivanpauno merged commit f765113 into ros2:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants