Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cppcheck error #229

Merged
merged 1 commit into from
May 13, 2020
Merged

Fix cppcheck error #229

merged 1 commit into from
May 13, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 13, 2020 •
edited
Loading

Precisely what the title says. See this job for a failure example. .

@hidmic
Fix cppcheck error.
0d46bf1 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from ivanpauno May 13, 2020 17:54
@hidmic
Copy link
Contributor Author

hidmic commented May 13, 2020

CI up to ros2cli, launch, launch_ros, rmw and ament_lint:

  • Linux Build Status

ivanpauno
ivanpauno approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that failure when I ran CI, but maybe I omitted it.

@hidmic
Copy link
Contributor Author

hidmic commented May 13, 2020

I didn't see that failure when I ran CI, but maybe I omitted it.

It doesn't show up in rmw, but in source files of downstream packages that include it e.g. rmw_connext_shared_cpp which is included in above's CI run.

@hidmic hidmic merged commit ee559fa into master May 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/lint branch May 13, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @ivanpauno