Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rmw_service_server_is_available doc #280

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 28, 2020

Update rmw_service_server_is_available doc. rmw_service_server_is_available returns RMW_RET_INCORRECT_RMW_IMPLEMENTATION.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 28, 2020

Compiling up-to rmw and testing rmw:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dealt with by #277 BUT we haven't updated implementations yet, so let's go with this as-is. Thanks @ahcorde !

@ahcorde ahcorde merged commit f6a79f6 into master Sep 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/doc/rmw_service_server_is_available branch September 28, 2020 18:50
ahcorde added a commit that referenced this pull request Oct 13, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 13, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants