Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new QoS policy data types to rmw #173

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Add new QoS policy data types to rmw #173

merged 3 commits into from
Apr 16, 2019

Conversation

mm318
Copy link
Member

@mm318 mm318 commented Apr 12, 2019 •
edited
Loading

Adds more fields to the rmw_qos_profile_t struct to specify liveliness, deadline, and lifespan QoS policies.
Also, adds new structs for conveying liveliness and deadline QoS statuses.
These changes are required for implementing the upcoming QoS features.

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Apr 12, 2019
emersonknapp
emersonknapp reviewed Apr 12, 2019
View reviewed changes
rmw/include/rmw/types.h Outdated Show resolved Hide resolved
rmw/include/rmw/types.h Outdated Show resolved Hide resolved
rmw/include/rmw/types.h Show resolved Hide resolved
@emersonknapp emersonknapp mentioned this pull request Apr 12, 2019
Merged
@mm318 mm318 mentioned this pull request Apr 12, 2019
Merged
@ross-desmond ross-desmond mentioned this pull request Apr 12, 2019
Merged
@mm318 mm318 mentioned this pull request Apr 12, 2019
Merged
This was referenced Apr 12, 2019
Merged
Merged
@mm318
Copy link
Member Author

mm318 commented Apr 13, 2019 •
edited
Loading

@thomas-moulard - please run the following CI job:

@thomas-moulard
Copy link

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mm318
Copy link
Member Author

mm318 commented Apr 13, 2019

Just realized that I needed to rebase since ros2/rclcpp#673 was merged.

@mm318
add new qos policy data types
d770c41 
Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318
address some of the feedback in the pull request
0942523 
Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318
Copy link
Member Author

mm318 commented Apr 15, 2019

Hi @wjwwood, this PR is ready for review. It and its associated PRs make no functional changes.

@mm318
Copy link
Member Author

mm318 commented Apr 15, 2019

Hi @wjwwood, this PR should be prioritized. It (and its connected PRs) should be the next QoS-related PR to be merged in, even before #171 (and its connected PRs).

@thomas-moulard
Copy link

Re-running CI now that the PR is rebased.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though the one sentence per line thing should be fixed before merging.

rmw/include/rmw/types.h Show resolved Hide resolved
rmw/include/rmw/types.h Outdated Show resolved Hide resolved
@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 16, 2019
@mm318
correct comments/docblock formatting
8d72731 
Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318
Copy link
Member Author

mm318 commented Apr 16, 2019

Should be ready to be merged. Thanks!

@wjwwood wjwwood merged commit ba0a717 into ros2:master Apr 16, 2019
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@emersonknapp emersonknapp emersonknapp approved these changes

Assignees

@mm318 mm318

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mm318 @thomas-moulard @wjwwood @emersonknapp @tfoote