Add function for getting clients by node #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2019
mjcarroll
approved these changes
Jun 12, 2019
This was referenced Jun 12, 2019
|
Full CI with all connected PRs:
|
|
The OpenSplice pendulum tests are known failures on Linux aarch64 (ros2/build_farmer#133), but looks like this has possibly introduced a similar failure for Linux amd64. There's a number of failures on macOS that I haven't seen before; I'll take a closer look. |
|
The test failures are not new. They are related to building with OpenSplice which we are not doing regularly (only release builds nightly where the failures do not appear). See ros2/rmw_opensplice#264 (comment) for builds against master where the same test failures appear. |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/get_clients_by_node
branch
2 times, most recently
from
b5f3dcc
to
f9c6283
Compare
|
Rebased all connected PRs:
EDIT: All of the failures already exist with default branches with OpenSplice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to distinguish between service clients and service servers when querying the ROS graph for services.
In particular, this will help resolve ros2/sros2#94.