Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Filtering empty names with naive approach #362

Merged
merged 4 commits into from
Dec 11, 2019
Merged

Filtering empty names with naive approach #362

merged 4 commits into from
Dec 11, 2019

Conversation

CaptainTrunky
Copy link
Contributor

@CaptainTrunky CaptainTrunky commented Jul 1, 2019 •
edited
Loading

Connects to ros2/ros2#489

A pull request for #489 basic implementation that allocates a temporary buffer for node names and filters out all empty names. It's not properly tested yet and additional unit tests are required. So next steps are:

PS
had to reopen PR because rebasing all the 6+ month old changes is way too painful to be productive.

Signed-off-by: captaintrunky captaintrunky@gmail.com

@CaptainTrunky CaptainTrunky mentioned this pull request Jul 1, 2019
Closed
5 tasks
@CaptainTrunky
Copy link
Contributor Author

Finally I've finished merging with current master.

@CaptainTrunky CaptainTrunky mentioned this pull request Jul 1, 2019
Merged
jacobperron
jacobperron suggested changes Jul 3, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are empty node names, then the list of node namespaces will be larger than the list of names.
We also need to return a shortened list of node namespaces. Using a similar strategy by keeping a temporary list of node namespaces should work.

rmw_connext_shared_cpp/src/node_names.cpp Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
@nuclearsandwich nuclearsandwich added in progress Actively being worked on (Kanban column) requires-changes labels Aug 8, 2019
@nuclearsandwich
Copy link
Member

@CaptainTrunky do you have plans to resume iterating on this PR? Thanks.

@jacobperron
Copy link
Member

@CaptainTrunky Friendly ping 🙂 Let us know if you'd like to keep working on this.

@CaptainTrunky
Copy link
Contributor Author

Sorry, I've been busy with my job. I'll try to resolve current issues within next two weeks.

@dirk-thomas
Copy link
Member

@CaptainTrunky Another ping

@CaptainTrunky
Copy link
Contributor Author

I've added support for namespaces. Plan to to test it on Wednesday and push final version.

jacobperron
jacobperron reviewed Oct 24, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaptainTrunky Thanks for iterating on this!

I've left a few more comments that I think need to be addressed before I trigger CI.

rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/node_names.cpp Outdated Show resolved Hide resolved
@CaptainTrunky CaptainTrunky force-pushed the 489_fixing_empty_node_names branch 3 times, most recently from 6497482 to cf92310 Compare November 11, 2019 16:23
@CaptainTrunky @jacobperron
Filtering empty names with naive approach
ae7fff2 
Signed-off-by: captaintrunky <captaintrunky@gmail.com>
@CaptainTrunky @jacobperron
Update node_names.cpp
09ce94c 
* removing <iostream>
* removing debug output
* removing redundant tmp_namespaces_num
* allowing empty namespaces
* tmp_names.size() must be equal to tmp_namespaces_num.size()
* unifying cleanup procedures

Signed-off-by: captaintrunky <captaintrunky@gmail.com>
@jacobperron
Declare variables before first goto
71a5c60 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix lint errors
68f59bb 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member

jacobperron commented Nov 26, 2019 •
edited
Loading

Sorry for the delay in getting back to this. I've rebased on master and added a small fix (70e6973) and resolved linter errors (68f59bb).

Running CI for all platforms to see where we stand:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: Rebuild with Connext only:

  • Linux Build Status
  • Linux-aarch64 Build Status (not supported)
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed requires-changes in progress Actively being worked on (Kanban column) labels Dec 10, 2019
@jacobperron jacobperron merged commit 223315a into ros2:master Dec 11, 2019
jacobperron
jacobperron approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaptainTrunky Thanks for iterating!

@sloretz sloretz mentioned this pull request Jan 13, 2020
Closed
jacobperron added a commit that referenced this pull request Jan 16, 2020
@jacobperron
Add missing namespace to the list when getting node names
a279d4a 
Fixes a bug introduced in #362.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Jan 16, 2020
Merged
jacobperron added a commit that referenced this pull request Jan 16, 2020
@jacobperron
Add missing namespace to the list when getting node names (#384)
49925b0 
Fixes a bug introduced in #362.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@dirk-thomas dirk-thomas dirk-thomas left review comments

@ivanpauno ivanpauno ivanpauno left review comments

Assignees
No one assigned
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CaptainTrunky @nuclearsandwich @jacobperron @dirk-thomas @ivanpauno