Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Stubs for rmw_get_publishers_info_by_topic and rmw_get_subscriptions_info_by_topic #377

Merged
merged 7 commits into from
Jan 14, 2020

Conversation

jaisontj
Copy link
Contributor

@jaisontj jaisontj commented Oct 22, 2019

NOTE: DO NOT MERGE until rmw #186 and rmw_implementation #72 are merged.

Leaving stubs for rmw_get_publishers_info_by_topic and rmw_get_subscriptions_info_by_topic as per discussion here

Related to - aws-roadmap#94

Copy link

@prajakta-gokhale prajakta-gokhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jaisontj jaisontj force-pushed the jaisontj/stub_rmw_get_topic_info branch from afb8b3f to c6d7ae3 Compare November 18, 2019 21:16
@jaisontj
Copy link
Contributor Author

@ivanpauno

Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment than here ros2/rmw_opensplice#289 (review).

rmw_connext_dynamic_cpp/src/functions.cpp Show resolved Hide resolved
rmw_connext_dynamic_cpp/src/functions.cpp Outdated Show resolved Hide resolved
rmw_connext_dynamic_cpp/src/functions.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/topic_info.cpp Outdated Show resolved Hide resolved
rmw_connext_shared_cpp/src/topic_info.cpp Outdated Show resolved Hide resolved
@jaisontj
Copy link
Contributor Author

Issue to track implementation of these stubs is here

rmw_get_subscriptions_info_by_topic.

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
@mm318 mm318 force-pushed the jaisontj/stub_rmw_get_topic_info branch from fed79ad to 0aee62d Compare December 11, 2019 20:01
Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318 mm318 force-pushed the jaisontj/stub_rmw_get_topic_info branch from 0aee62d to dde52b5 Compare December 11, 2019 20:01
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with the understanding that these won't be left unimplemented for long since this is one of our two tier 1 rmw implementations.

rmw_connext_cpp/src/rmw_get_topic_info.cpp Outdated Show resolved Hide resolved
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
@ivanpauno ivanpauno merged commit 184f6d2 into ros2:master Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants