This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Stubs for rmw_get_publishers_info_by_topic and rmw_get_subscriptions_info_by_topic #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaisontj
force-pushed
the
jaisontj/stub_rmw_get_topic_info
branch
from
1993ca1
to
24c11f4
Compare
jaisontj
force-pushed
the
jaisontj/stub_rmw_get_topic_info
branch
from
24c11f4
to
746e67c
Compare
|
It is, but the error is because this PR has not been merged and that PR is the one that defines the required structs needed for this one. I've updated the PR description to say the same. |
rmw_get_subscriptions_info_by_topic Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
jaisontj
force-pushed
the
jaisontj/stub_rmw_get_topic_info
branch
from
746e67c
to
7ce2489
Compare
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
ivanpauno
reviewed
Dec 10, 2019
|
A similar PR is missing for https://github.com/ros2/rmw_cyclonedds/. |
Issue created here. |
wjwwood
approved these changes
Jan 8, 2020
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
ivanpauno
approved these changes
Jan 10, 2020
ivanpauno
reviewed
Jan 13, 2020
| // limitations under the License. | ||
|
|
||
| #include "rmw/error_handling.h" | ||
| #include "rmw/get_topic_info.h" |
There was a problem hiding this comment.
@mm318 CI I've ran failed because of the unupdated name.
There was a problem hiding this comment.
Oops, my editor somehow missed that file.
@ivanpauno, can you please run the CI again? Thanks!
Signed-off-by: Miaofei <miaofei@amazon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: DO NOT MERGE until rmw #186 and rmw_implementation #72 are merged.
Leaving stubs for
rmw_get_publishers_info_by_topicandrmw_get_subscriptions_info_by_topicas per discussion hereRelated to - aws-roadmap#94