fix: "Failed to parse type hash" message was overly spammy [ros2-50] #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taxo Rubio <trubio@rti.com>
|
Full CI:
|
fujitatomoya
approved these changes
May 7, 2024
|
In 🧇 meeting we talked about taking this change and also adding a "log once". The log once call would say there was a type mismatch, and tell users to switch the logging mode to debug to see more info. Looking closer I now see that this is using an rmw_connext specific logging macro, and there's no log-once equivalent. @clalancette what do you think about taking this change as-is? |
trubio-rti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this message printed with too high of a verbosity level makes it too spammy in normal executions of the RMW, making it hard to work with the log files.