Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take and return new RMW_DURATION_INFINITE correctly #288

Merged

Conversation

emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Feb 19, 2021

Depends on ros2/rmw#301
Alternative to #287

Meets the new API expectations introduced in ros2/rmw#301 - to accept and return RMW_DURATION_INFINITE for cross-implementation consistency.

Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emerson Knapp added 3 commits March 11, 2021 11:16
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/rmw_qos_time_infinite branch from c1ed9b6 to 5c6b30a Compare March 11, 2021 19:17
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Mar 11, 2021

@eboasson @ivanpauno friendly ping - the dependent RMW PR has been merged, so this is ready to go. I notice that the actions here are not working since November (https://github.com/ros2/rmw_cyclonedds/actions?query=event:push+branch:master) , and I'm not sure I want to mess around with your specific CI setup - so what is the next step?

@ivanpauno
Copy link
Member

ivanpauno commented Mar 11, 2021

@emersonknapp can you run CI for this?

for the Rpr checker to pass you would need someone releasing rmw to rolling.
The other jobs are failing because of unrelated reasons (this line, I think master can be used now).

@ivanpauno ivanpauno mentioned this pull request Mar 11, 2021
@clalancette
Copy link
Contributor

clalancette commented Mar 11, 2021

I think we should aim for at least the Rpr job to go green (along with the usual https://ci.ros2.org jobs). I can do an rmw release a little later.

@emersonknapp
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/emersonknapp/6c22d23c3fac5b8ced3605986aa33a46/raw/fb33f2320709a25cfb79267321a16e57dc0f4eb9/ros2.repos
BUILD args: --packages-up-to rmw_cyclonedds_cpp rcl
TEST args: --packages-select rmw_cyclonedds_cpp rcl
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/7855

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

FYI, I did do an rmw release. Given how low-level it is, it will take a few hours to finish building "everything", but once that is done the PR job should be able to compile.

@ivanpauno
Copy link
Member

@ros-pull-request-builder retest this please

@ivanpauno ivanpauno merged commit b18a102 into ros2:master Mar 12, 2021
clalancette pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants