-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed rosidl_generator_cpp with rosidl_runtime_cpp #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Apr 6, 2020
ivanpauno
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI!
dirk-thomas
reviewed
Apr 6, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
Apr 7, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
Apr 7, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
Apr 8, 2020
ivanpauno
approved these changes
Apr 8, 2020
In MacOS
Windows
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR as part of the effort to split
rosidl_generator
in two partrosidl_generator_x
androsidl_runtime_x
Header are now located in
rosidl_runtime_cpp
package not in therosild_generator_cpp
package.As @dirk-thomas request in this issue #9,
rosidl_generator_cpp
could not be a runtime dependency because it does not contain any.so/dll/dylib
. I changed this in thepackage.xml
to<buildtool_depend>
andbuildtool_export_depend
Signed-off-by: ahcorde ahcorde@gmail.com