Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows warning #7

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Fix windows warning #7

merged 3 commits into from
Apr 3, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Apr 3, 2020 •
edited
Loading

Fixes #5.

  • Windows Build Status

@ivanpauno
Replace std::strncpy with strncpy
4056c43 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Use memncpy instead of strncpy
c15a043 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Fix error
fd26d27 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review The pull request is waiting to be reviewed label Apr 3, 2020
@ivanpauno ivanpauno requested a review from ahcorde April 3, 2020 19:43
@ivanpauno ivanpauno self-assigned this Apr 3, 2020
ahcorde
ahcorde approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno ivanpauno merged commit 052acc3 into master Apr 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-windows-warning branch April 3, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@ivanpauno ivanpauno

Labels
in review The pull request is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning in strncpy rmw_dds_common
2 participants
@ivanpauno @ahcorde