Call callbacks only if unread count > 0 #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
suggested changes
Sep 22, 2022
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
mauropasse
force-pushed
the
mauro/rolling-fixes
branch
from
ad54e8c
to
43aea82
Compare
|
CI:
|
|
Green CI and approved, so merging. |
|
@Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2022
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> (cherry picked from commit 972167c)
✅ Backports have been created
|
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> (cherry picked from commit 972167c)
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listener callbacks for QoS events were being called when assigned.
They should be called here only if there were previous events before setting these callbacks.
This PR checks the
total_count_changefor each event, and if greater than zero, call the corresponding callback.Signed-off-by: Mauro Passerino mpasserino@irobot.com