-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in support for the MESSAGE_LOST event. #584
Conversation
Fast-DDS (and rmw_fastrtps_cpp) don't fully support this right now, but having it in the list here allows RViz2 to start up. Implementation extracted from #583, which is the more complete solution. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette This LGTM pending green CI, but I wonder, why not simply review and merge #584?
I assume you mean #583. The main reason is that #583 is adding in support for some other events as well, and that is causing lots of spam on the terminal, as well as failed tests. I want to get just this piece of it in ASAP, because until this is in RViz2 is completely broken on Rolling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the approach, but looks good for the most part.
@clalancette @fujitatomoya Please see my comment on #583 |
Closing since we merged #583 in instead. |
Fast-DDS (and rmw_fastrtps_cpp) don't fully support this right
now, but having it in the list here allows RViz2 to start up.
Implementation extracted from
#583, which is the more
complete solution.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This also requires a small fix in rcl, which is upcoming.
@MiguelCompany FYI. We really need to fix RViz2, and the only part we need in order to do that is the MESSAGE_LOST fix. So this just extracts the necessary bits from #583 so we can get it in faster. We can rebase 583 on top of this later on.