Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node graph functions #49

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

ross-desmond
Copy link
Contributor

@ross-desmond ross-desmond commented Nov 16, 2018

  • rmw_get_subscriber_names_and_types_by_node
  • rmw_get_publisher_names_and_types_by_node
  • rmw_get_service_names_and_types_by_node

Connects to ros2/rcl#333

@tfoote tfoote added the in review Waiting for review (Kanban column) label Nov 16, 2018
@ross-desmond
Copy link
Contributor Author

Connected to rcl

@ross-desmond ross-desmond mentioned this pull request Nov 20, 2018
34 tasks
@thomas-moulard
Copy link

Confirmed tests are passing locally.

@dirk-thomas
Copy link
Member

The commit list in this PR currently contains several unrelated commits. It would be good to clean this up so that it is obvious what changes are part of this patch.

* rmw_get_subscriber_names_and_types_by_node
* rmw_get_publisher_names_and_types_by_node
* rmw_get_service_names_and_types_by_node
@clalancette
Copy link
Contributor

I just force pushed to cleanup the history. There is no functional change.

@jacobperron jacobperron merged commit 7bacef7 into ros2:master Dec 7, 2018
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants