Skip to content

Commit

Permalink
Switch wait_for_all_acked to return OK. (#215)
Browse files Browse the repository at this point in the history
This just keeps upper-layer tests working.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
  • Loading branch information
clalancette committed Jun 26, 2024
1 parent 2cfdd3b commit e73df29
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion rmw_zenoh_cpp/src/rmw_zenoh.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,13 @@ rmw_publisher_wait_for_all_acked(
{
static_cast<void>(publisher);
static_cast<void>(wait_timeout);
return RMW_RET_UNSUPPORTED;

// We are not currently tracking all published data, so we don't know what data is in flight that
// we might have to wait for. Even if we did start tracking it, we don't have insight into the
// TCP stream that Zenoh is managing for us, so we couldn't guarantee this anyway.
// Just lie to the upper layers and say that everything is working as expected.
// We return OK rather than UNSUPPORTED so that certain upper-layer tests continue working.
return RMW_RET_OK;
}

//==============================================================================
Expand Down

0 comments on commit e73df29

Please sign in to comment.