Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rmw_zenoh_cpp namespace #168

Merged
merged 5 commits into from May 17, 2024
Merged

Add rmw_zenoh_cpp namespace #168

merged 5 commits into from May 17, 2024

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented May 4, 2024 •
edited

This PR adds the rmw_zenoh_cpp namespace to all internal definitions except rmw_context_impl_s as per expectation defined in rmw/init.h.

Fixes #60 but without a detail namespace. I felt it is not needed but let me know otherwise.

@Yadunund
Namespace
d0ed920 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund
More namespacing
369dfad 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund requested a review from clalancette May 4, 2024 01:20
clalancette
clalancette requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few things to fix, but generally it looks good to me.

rmw_zenoh_cpp/src/detail/graph_cache.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/detail/graph_cache.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/detail/rmw_data_types.cpp Show resolved Hide resolved
rmw_zenoh_cpp/src/detail/rmw_data_types.hpp Show resolved Hide resolved
@Yadunund
Check for lost messages in sub_data_handler (#169)
e7aad9b 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund
Merge branch 'rolling' into yadu/namespace
05a44fc
@Yadunund
Address feedback
2a293d4 
Signed-off-by: Yadunund <yadunund@intrinsic.ai>
@Yadunund Yadunund requested a review from clalancette May 17, 2024 00:02
@Yadunund Yadunund merged commit 2a12b34 into rolling May 17, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the yadu/namespace branch May 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@Yadunund Yadunund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing rmw_zenoh_cpp namespace
2 participants
@Yadunund @clalancette