Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support topic instances in DDS topics #1538

Open
MiguelCompany opened this issue Apr 1, 2024 · 4 comments
Open

Support topic instances in DDS topics #1538

MiguelCompany opened this issue Apr 1, 2024 · 4 comments

Comments

@MiguelCompany
Copy link
Contributor

MiguelCompany commented Apr 1, 2024 •
edited
Loading

Feature request

Support processing of members annotated with @key

Feature description

Allowing the user to aggregate several topics into a single topic with several instances by leveraging the usage of @key annotation.

See here for motivation and proposed tutorials.

Implementation considerations

Related PRs:
This was referenced Apr 1, 2024
Merged
Merged
Open
Open
Open
@MiguelCompany
Copy link
Contributor Author

@clalancette The PRs mentioned here are ready for review. Tests are passing locally with --packages-up-to test_communication

@asorbini @eboasson You might want to take a look and incorporate the necessary changes to your RMWs so we interoperate on keyed topics

@ahcorde
Copy link
Contributor

ahcorde commented Apr 5, 2024 •
edited
Loading

As we discussed offline we are going to launch full CI with the two rosidl PRs

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows Debug Build Status

@MiguelCompany
Copy link
Contributor Author

@ahcorde I rebased the first two PRs yesterday to get ros2/rosidl#795. That should have fixed the linter failures from the runs on 2024-04-05.

@ahcorde
Copy link
Contributor

ahcorde commented Apr 8, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows Debug Build Status

@fujitatomoya fujitatomoya mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahcorde @MiguelCompany