Adding interfaces to support @key annotation
#116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
7dffcb9
to
61072ed
Compare
ahcorde
requested changes
Apr 8, 2024
| @[ if key[0] != package_name]@ | ||
| ROSIDL_TYPESUPPORT_FASTRTPS_C_IMPORT_@(package_name) | ||
| @[ end if]@ | ||
| size_t get_serialized_size_key_@('__'.join(key))( |
| * \param [in,out] is_unbounded Whether the key has any unbounded member. | ||
| * \return The maximum key serialized size, in bytes. | ||
| */ | ||
| size_t (* max_serialized_size_key)( |
| /// Callback function for key serialization | ||
| /** | ||
| * \param[in] untyped_ros_message Type erased pointer to message instance. | ||
| * \param [in,out] Fast CDR serializer. |
There was a problem hiding this comment.
Suggested change
| * \param [in,out] Fast CDR serializer. | |
| * \param [in,out] cdr Fast CDR serializer. |
| ROSIDL_TYPESUPPORT_FASTRTPS_CPP_PUBLIC_@(package_name) | ||
| get_serialized_size_key( | ||
| const @('::'.join([package_name] + list(interface_path.parents[0].parts) + [message.structure.namespaced_type.name])) & ros_message, | ||
| size_t current_alignment); |
| bool cdr_serialize_key( | ||
| const @('::'.join(type_.namespaced_name())) &, | ||
| eprosima::fastcdr::Cdr &); | ||
| size_t get_serialized_size_key( |
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
|
mjcarroll
added a commit
that referenced
this pull request
Apr 9, 2024
Bug introduced in #116 Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary interfaces to support
@keyannotation in RMW implementations using Fast CDRPart of ros2/ros2#1538
Depends on ros2/rosidl#796