-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta-ticket]: Add pytest.ini to all packages which use pytest #951
Comments
We'll also likely have to backport these to Dashing and Eloquent and Foxy to keep the warnings down there. |
The single failure in macOS and Windows is there in nightlies. So I think these are good to start reviewing and merging. |
All right, all failures in CI are also in nightlies. |
All right, these are all in now. In theory, we could remove the pytest.ini workaround from CI; however, if we do that, we'll break CI for Dashing, Eloquent, and Foxy. The obvious solution is to backport all of these changes to all of those active distributions, which would finally allow us to close ros2/ci#471 , but is also a lot of churn (27*3 == 81 PRs to do this). |
We could also just remove the CI workaround for Foxy and rolling to ensure we don't accidentally reintroduce a problem. |
All right, since I've now done this in ros2/ci#497, I'm going to close this tracking ticket. Thanks for the feedback and reviews here. |
Signed-off-by: Arne Nordmann (CR/AEA2) <arne.nordmann@de.bosch.com>
In the current state, if you run any of the pytest tests locally, you get warning messages like:
We currently workaround this in CI by always adding a pytest.ini before starting tests (see ros2/ci#471), but it would be nice to get rid of that and just have local and CI work the same.
This is a tracking bug for all of the places we need to change it. Once I've opened the relevant PRs, I'll run one CI job for all of them here.
The text was updated successfully, but these errors were encountered: