Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf2 Concept: About tf2 page #1951
tf2 Concept: About tf2 page #1951
Changes from 4 commits
abc3f30
dcc5c79
1b6a9c6
233d8fc
5dfbf59
daa2ffa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kurshakuz@daa2ffa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like the idea of providing the reference, we should be careful to explain that the paper was about the original
tf
, nottf2
. In particular, the concepts in tf and tf2 are the same, though the implementation and API are very different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paper itself actually does not mention anything specific to first tf API. The paper is nice as it covers the very basics of broadcasting and listening, transformations in time and how the transform computation works. I do think that we better mention it.
Originally, paper was directly included in the wiki and I think its even better if we can host it in the docs too. I am myself don't have access to that ieeexplore database, unfortunately.
https://wiki.ros.org/Papers/TePRA2013_Foote?action=AttachFile&do=view&target=TePRA2013_Foote.pdf
Do you think we can include it somewhere and add a link to it? Does current docs website support that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add arbitrary files, but I'm not sure. I'd have to do some more looking at the Sphinx documentation. For now, I'm happy to leave this link and we can look at adding in the paper later.