Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ros2trace tests to new test_ros2trace package #63

Conversation

christophebedard
Copy link
Member

Follow-up to #54 and #58

The ros2trace tests depend on the ignored test_tracetools package, so move them to a new test_ros2trace package which we will ignore as well.

@christophebedard christophebedard self-assigned this Apr 18, 2023
@christophebedard
Copy link
Member Author

christophebedard commented Apr 18, 2023

Marking this as a draft until Rolling is unfrozen. Merging this now to fix buildfarm job for ros2trace

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/extract-ros2trace-tests-to-new-test-ros2trace-package branch from c0e256c to cfa72c4 Compare April 18, 2023 16:40
@christophebedard christophebedard marked this pull request as ready for review April 18, 2023 20:40
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me with green CI.

For efficiency sake, I think it is enough to run CI with a build --packages-up-to ros2trace test_ros2trace and a test of --packages-select ros2trace test_ros2trace.

Note that we are explicitly going to break the Iron freeze for this, because these tests are currently causing a hang when building binary packages. With them in a separate package we can ignore them in the release repository and never try to build binary packages for them at all.

@christophebedard
Copy link
Member Author

Building --packages-up-to ros2trace test_ros2trace, testing --packages-select ros2trace test_ros2trace:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette added this to In progress in Iron Irwini via automation Apr 18, 2023
@christophebedard christophebedard merged commit 045e892 into rolling Apr 18, 2023
Iron Irwini automation moved this from In progress to Done Apr 18, 2023
@christophebedard christophebedard deleted the christophebedard/extract-ros2trace-tests-to-new-test-ros2trace-package branch April 18, 2023 21:52
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-iron-branching-on-rolling-2023-04-18/30980/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants