Improve 'ros2 trace' command error handling & add end-to-end tests #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
from
969bd22
to
e3ccea0
Compare
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
2 times, most recently
from
f2f16f0
to
c3d1004
Compare
|
Hmm maybe these tests shouldn't rely on tracepoints being included. Or maybe they could be skipped if tracepoints are not included. |
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
from
c3d1004
to
e4c037f
Compare
I did this. |
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
3 times, most recently
from
90648ca
to
dd219e3
Compare
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
from
dd219e3
to
f4ad3f3
Compare
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
4 times, most recently
from
9c863ac
to
e789b18
Compare
|
Testing
|
mjcarroll
approved these changes
Apr 17, 2023
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
christophebedard
force-pushed
the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
from
e789b18
to
ed7c144
Compare
christophebedard
changed the title
christophebedard
deleted the
christophebedard/ros2-trace-command-end-to-end-tests-and-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Closes #36
This improves error handling and error report in
tracetools_trace. The common functions used byros2trace(for theros2 tracecommand) andtracetools_launch(for theTracelaunch action) now do not print anything; they raise exceptions where appropriate. Then,ros2 trace/Tracecan catch any error and report it using the appropriate method: print tostderrforros2 traceand log error forTrace.This also makes sure to destroy the tracing session if it exists when tracing configuration fails.
Finally, this adds end-to-end tests for the
ros2 tracecommand to cover the main cases. It also improves parameter validation for the session name.Signed-off-by: Christophe Bedard christophe.bedard@apex.ai