Split test cases and add some more

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

ros2node/test/test_node.py

@@ -38,7 +38,13 @@ def test_parse_node_name():
     assert name.name == 'talker'
 
 
-def test_duplicate_names():
+def test_annotate_duplicate_nodes_empty():
+    any_duplicates, printable_names = annotate_duplicate_nodes([])
+    assert not any_duplicates
+    assert len(printable_names) == 0
+
+
+def test_annotate_duplicate_nodes_simple_unique():
     all_unique_names = [
         NodeName('foo', 'ns_foo', 'ns_foo/foo'),
         NodeName('bar', 'ns_foo', 'ns_foo/bar'),
@@ -51,13 +57,29 @@ def test_duplicate_names():
         'ns_foo/foo',
     ]
 
-    all_unique_names = [
+
+def test_annotate_duplicate_nodes_simple_nonunique():
+    non_unique_names = [NodeName('foo', 'ns_foo', 'ns_foo/foo')] * 2
+    any_duplicates, printable_names = annotate_duplicate_nodes(non_unique_names)
+    assert any_duplicates
+    assert printable_names == ['ns_foo/foo (non-unique name)'] * 2
+
+    non_unique_names = [NodeName('foo', 'ns_foo', 'ns_foo/foo')] * 3
+    any_duplicates, printable_names = annotate_duplicate_nodes(non_unique_names)
+    assert any_duplicates
+    assert printable_names == ['ns_foo/foo (non-unique name)'] * 3
+
+
+def test_annotate_duplicate_nodes_mixed_uniqueness():
+    mixed_unique_names = [
+        NodeName('bar', 'ns_foo', 'ns_foo/bar'),
         NodeName('foo', 'ns_foo', 'ns_foo/foo'),
         NodeName('foo', 'ns_foo', 'ns_foo/foo'),
     ]
-    any_duplicates, printable_names = annotate_duplicate_nodes(all_unique_names)
+    any_duplicates, printable_names = annotate_duplicate_nodes(mixed_unique_names)
     assert any_duplicates
     assert printable_names == [
+        'ns_foo/bar',
         'ns_foo/foo (non-unique name)',
         'ns_foo/foo (non-unique name)',
     ]