Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide window of spawned daemon #113

Merged
merged 1 commit into from
Jun 26, 2018
Merged

hide window of spawned daemon #113

merged 1 commit into from
Jun 26, 2018

Conversation

dirk-thomas
Copy link
Member

Fixes #108.

I didn't run CI for this but ran the package tests locally as well as the actual verb on a Windows machine.

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Jun 25, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 25, 2018
sloretz
sloretz approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@dirk-thomas dirk-thomas merged commit 3ed3dce into master Jun 26, 2018
@dirk-thomas dirk-thomas deleted the hide_daemon_windows branch June 26, 2018 20:45
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 26, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
@jacobperron
Fix LoadComposableNodes action so that loading happens asynchronously (…
4f03b24 
…ros2#113)

Fixes ros2#107.

Before, the first call to _load_in_sequence was not asynchronous, unlike it's recursive calls.
This change makes the first call asynchronous.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @sloretz