add slash for node name #179
Conversation
|
It seems a bit odd to make this same transformation in every different verb. Is there a reason not to create a |
|
Nevermind, I just found out that we have this already in |
|
There could be a function to do this in rcl and it could be exposed via rclpy, like the expand topic name function: |
|
So my referenced function does actually not really help. It does pretty much the opposite. I guess I stick with my reasoning then that the rcl solution would be preferred but given the time I think it's not feasible. |
|
I just introduced a new small function in @wjwwood @jacobperron please iterate one more time over this. Also feel free to directly push on this ticket if you see room for improvement :) |
crystal now accepts leading slash ros2/ros2cli#179
* [Node Arguments] Python nodes support parameters Python nodes in Crystal support parameters ros2 param list requires fully qualified node name (will file bug on ros2cli) * Update Node-arguments.rst * Separate block for bouncy * Note about parameters in bouncy in documentation * Revert changes to ros2 param list command crystal now accepts leading slash ros2/ros2cli#179 * Whitespace removal
|
Was the |
* [Node Arguments] Python nodes support parameters Python nodes in Crystal support parameters ros2 param list requires fully qualified node name (will file bug on ros2cli) * Update Node-arguments.rst * Separate block for bouncy * Note about parameters in bouncy in documentation * Revert changes to ros2 param list command crystal now accepts leading slash ros2/ros2cli#179 * Whitespace removal
* Support required nodes
Currently, the only way to specify that a given node is required for a
given `LaunchDescription` is to register an `OnProcessExit` handler for
the exit event of the required node that then emits a `Shutdown` event.
Instead of requiring this boilerplate for a common use-case, add an
`on_exit` parameter to `ExecuteProcess` that can take actions, and add a
new action called `Shutdown` that immediately causes the launched system
to shut down. This allows for the concept of a required node to be
expressed simply with:
launch_ros.actions.Node(
# ...
on_exit=Shutdown()
)
Resolve ros2#174
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
* Inherit from EmitEvent
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
* Properly align type
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
* Expose reason
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
same fix as for get: #174