Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix param list for nodes which don't have the service #265

Merged
merged 1 commit into from
May 29, 2019
Merged

fix param list for nodes which don't have the service #265

merged 1 commit into from
May 29, 2019

Conversation

dirk-thomas
Copy link
Member

Fixes #185.

@dirk-thomas
fix param list for nodes which don't have the service
880d4e0 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels May 29, 2019
@dirk-thomas dirk-thomas self-assigned this May 29, 2019
@dirk-thomas dirk-thomas mentioned this pull request May 29, 2019
Closed
jacobperron
jacobperron approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes one issue, but there's still a problem when that the --include-hidden-nodes option doesn't display parameters for hidden nodes.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented May 29, 2019 •
edited
Loading

there's still a problem when that the --include-hidden-nodes option doesn't display parameters for hidden nodes.

That problem doesn't seem to be described in the referenced ticket? I would suggest to create a separate issue with sufficient information to track it.

@dirk-thomas dirk-thomas merged commit 0b75d70 into master May 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-param-list branch May 29, 2019 18:47
@jacobperron
Copy link
Member

Opened follow-up issue: #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ros2param] list misbehaves when hidden nodes are present
2 participants
@dirk-thomas @jacobperron