Add 'service type' verb #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artivis <jeremie.deray@canonical.com>
dirk-thomas
reviewed
Jun 7, 2019
ros2service/ros2service/verb/type.py
Outdated
|
|
||
| for (service_name, service_types) in service_names_and_types: | ||
| if args.service_name == service_name: | ||
| print(service_types[0]) |
There was a problem hiding this comment.
Why should this only print the first type? (I guess the same question applies to the previous topic PR.)
There was a problem hiding this comment.
First, can it really have several types ?? If so then this is a mistake.
I only print the first one for a formatting purpose, I could do the same with a loop I guess.
There was a problem hiding this comment.
can it really have several types ??
Yes, it can have multiple types. That is why the API returns a list of type names.
I could do the same with a loop I guess.
👍 one type per line sounds good.
Signed-off-by: artivis <jeremie.deray@canonical.com>
Merged
|
Thanks for the feature addition. |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Assert the client call succeeded Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Shutdown rclpy when test throws exceptions Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
typeverb toservicewhich return the type of a given service.E.g.
given
ros2 run demo_nodes_cpp talker