Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make network check case-insensitive #334

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Make network check case-insensitive #334

merged 2 commits into from
Sep 17, 2019

Conversation

claireyywang
Copy link
Contributor

Flags can be either lowercase or uppercase dependent on the system. This change checks for both cases.

claireyywang added 2 commits September 16, 2019 16:18
make network check case-insensitive
d01353a 
Signed-off-by: claireyywang <clairewang@openrobotics.org>
update case insensitive function call
547c08e 
Signed-off-by: claireyywang <clairewang@openrobotics.org>
@claireyywang claireyywang added the in review Waiting for review (Kanban column) label Sep 16, 2019
@claireyywang claireyywang self-assigned this Sep 16, 2019
@claireyywang
Copy link
Contributor Author

Linux: Build Status
Linux-aarch64 Build Status
OSX: Build Status
Windows: Build Status

@claireyywang claireyywang merged commit 5dc4d9b into master Sep 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the claire/add-case-insensitive-check branch September 17, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@claireyywang claireyywang

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@claireyywang @jacobperron