Move rosidl implementation details to rosidl_runtime_py #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves several TODOs. Here is the PR moving the related functions to their new home: ros2/rosidl_runtime_py#3 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
|
Does this need to land before #363 ? |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
No, this is a follow-up. |
|
wjwwood
approved these changes
Oct 19, 2019
hidmic
added a commit
that referenced
this pull request
Oct 22, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation has been moved and refactored in ros2/rosidl_runtime_py#3
This resolves several TODOs (5b54d70).
Also, using the abstracted functions it's easier to remove dependencies on packages deprecated in #363 (b01c63f).
Depends on ros2/rosidl_runtime_py#3