[ros2node] Add option to info verb to display hidden names #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes behavior so that hidden names are not shown by default. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
reviewed
Oct 21, 2019
* Remove check for empty topic * Pass keyword arg by name Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Which it uses for identifier component containers. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
dirk-thomas
approved these changes
Oct 21, 2019
| @@ -38,28 +38,34 @@ def add_arguments(self, parser, cli_name): | |||
| 'node_name', | |||
| help='Node name to request information') | |||
| argument.completer = NodeNameCompleter() | |||
| parser.add_argument( | |||
| '--include-hidden', action='store_true', | |||
| help='Display hidden topics, services, and actions as well') | |||
There was a problem hiding this comment.
Maybe a user wants to see hidden nodes but not hidden topics / services / actions - or the other way around? Just a thought...
There was a problem hiding this comment.
I presume you mean them wanting to see hidden topics, but not hidden services / actions (or some combination). I thought about it, but I figured it's a rare case to want to see any of the hidden names, let alone a subset.
mjcarroll
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes behavior so that hidden names are not shown by default.
Before this change, if we ran turtlesim and retrieved the node info we'd see hidden topics and services related to the action server, e.g.
$ ros2 node info /turtlesim /turtlesim Subscribers: /parameter_events: rcl_interfaces/msg/ParameterEvent /turtle1/cmd_vel: geometry_msgs/msg/Twist Publishers: /parameter_events: rcl_interfaces/msg/ParameterEvent /rosout: rcl_interfaces/msg/Log /turtle1/color_sensor: turtlesim/msg/Color /turtle1/pose: turtlesim/msg/Pose /turtle1/rotate_absolute/_action/feedback: turtlesim/action/RotateAbsolute_FeedbackMessage /turtle1/rotate_absolute/_action/status: action_msgs/msg/GoalStatusArray Services: /clear: std_srvs/srv/Empty /kill: turtlesim/srv/Kill /reset: std_srvs/srv/Empty /spawn: turtlesim/srv/Spawn /turtle1/rotate_absolute/_action/cancel_goal: action_msgs/srv/CancelGoal /turtle1/rotate_absolute/_action/get_result: turtlesim/action/RotateAbsolute_GetResult /turtle1/rotate_absolute/_action/send_goal: turtlesim/action/RotateAbsolute_SendGoal /turtle1/set_pen: turtlesim/srv/SetPen /turtle1/teleport_absolute: turtlesim/srv/TeleportAbsolute /turtle1/teleport_relative: turtlesim/srv/TeleportRelative /turtlesim/describe_parameters: rcl_interfaces/srv/DescribeParameters /turtlesim/get_parameter_types: rcl_interfaces/srv/GetParameterTypes /turtlesim/get_parameters: rcl_interfaces/srv/GetParameters /turtlesim/list_parameters: rcl_interfaces/srv/ListParameters /turtlesim/set_parameters: rcl_interfaces/srv/SetParameters /turtlesim/set_parameters_atomically: rcl_interfaces/srv/SetParametersAtomically Action Servers: /turtle1/rotate_absolute: turtlesim/action/RotateAbsolute Action Clients:Now, we can get the same output if we add the
--include-hiddenoption, but by default we don't see the hidden entities like/turtle1/rotate_absoulte/_action/cancel_goal: