-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only load required entry points which improves the performance #436
only load required entry points which improves the performance #436
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sorry, I was only approving the first commit, didn't realize that it marks the whole thing as approved, still looking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI and a small nit about documentation.
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
aef5a5c
to
7cc848f
Compare
While the Windows build has a very high test failure count (75) that seems to match the latest nightly Windows Debug build: https://ci.ros2.org/view/nightly/job/nightly_win_deb/1504/ Merging... |
I noticed that autocomplete isn't working at all in master in all the ros2 cli tools. @dirk-thomas can you take a look? If not, I can try to fix it (though I don't have much context). |
Follow up of #424.
The changes are split over four commits to ease the review.