Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2b3 ros2param crashes with list / #51

Closed
sloretz opened this issue Sep 13, 2017 · 6 comments
Closed

r2b3 ros2param crashes with list / #51

sloretz opened this issue Sep 13, 2017 · 6 comments

Comments

@sloretz
Copy link
Contributor

sloretz commented Sep 13, 2017

Bug report

Required Info:

Steps to reproduce issue

ros2 run demo_nodes_cpp ros2param -- list /

Expected behavior

Not sure.

Actual behavior

ros2param.exe has stopped working

ros2param_list

Additional information

Not from source, so unable to get a meaningful stack trace.

@wjwwood
Copy link
Member

wjwwood commented Sep 13, 2017

I don't get this on my from source build, using master, pulled just about an hour ago.

capture

@wjwwood
Copy link
Member

wjwwood commented Sep 13, 2017

Were you running anything else at the time?

@dirk-thomas
Copy link
Member

Please move the ticket to the repo containing the failing script: https://github.com/ros2/demos/blob/6363be2efe2fea799d92bc22a66e776b2ca9c5d0/demo_nodes_cpp/src/parameters/ros2param.cpp

Also not that the C++ implementation of this command line tool is kind of EOL and is supposed to be replaced by a Python tool within the ros2cli repo. So I would suggest not to spend time on it.

@mikaelarguedas
Copy link
Member

hmm looks like it happens with "/" I tried random other names and if the node doesnt exist I get service not available, waiting again...

Were you running anything else at the time?

I can reproduce the error above regardless of if another node with parameter server is running or not

While I agree the crash is bad, this I don't really see any use case for an empty node name (resulting in a FQN "/")

@sloretz
Copy link
Contributor Author

sloretz commented Sep 13, 2017

Oops, sorry about the wrong repo again. Moving

@sloretz
Copy link
Contributor Author

sloretz commented Sep 13, 2017

This issue was moved to ros2/demos#174

@sloretz sloretz closed this as completed Sep 13, 2017
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants