Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Ensure consistent timeout in ros2component list. (#526) #539

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[foxy backport] Ensure consistent timeout in ros2component list. (#526) #539

merged 1 commit into from
Jun 23, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 22, 2020

With no deprecation notices nor warnings.

@hidmic
Ensure consistent timeout in ros2component list. (#526)
d9e73d0 
With no deprecation notices nor warnings.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from jacobperron June 22, 2020 23:09
@hidmic hidmic changed the title Ensure consistent timeout in ros2component list. (#526) [foxy backport] Ensure consistent timeout in ros2component list. (#526) Jun 22, 2020
jacobperron
jacobperron approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic merged commit 8bc6c1d into foxy Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/foxy/backport-526 branch June 23, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @jacobperron