Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard loading to ros2 param load #602

Merged
merged 4 commits into from
Feb 23, 2021

Conversation

v-lopez
Copy link
Contributor

@v-lopez v-lopez commented Feb 23, 2021

Related to #590 and #596

Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
@v-lopez v-lopez mentioned this pull request Feb 23, 2021
ros2param/ros2param/api/__init__.py Outdated Show resolved Hide resolved
ros2param/ros2param/verb/load.py Outdated Show resolved Hide resolved
@ivanpauno ivanpauno added the enhancement New feature or request label Feb 23, 2021
v-lopez and others added 2 commits February 23, 2021 14:47
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @v-lopez !!

@ivanpauno
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member

@v-lopez there are a few linter failures

Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
@ivanpauno
Copy link
Member

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 4848995 into ros2:master Feb 23, 2021
v-lopez added a commit to pal-robotics-forks/ros2cli that referenced this pull request Feb 23, 2021
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
ivanpauno pushed a commit that referenced this pull request Mar 5, 2021
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants