-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wildcard loading to ros2 param load #602
Merged
ivanpauno
merged 4 commits into
ros2:master
from
pal-robotics-forks:add-load-wildcard-support
Feb 23, 2021
Merged
Add wildcard loading to ros2 param load #602
ivanpauno
merged 4 commits into
ros2:master
from
pal-robotics-forks:add-load-wildcard-support
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Merged
ivanpauno
reviewed
Feb 23, 2021
v-lopez
force-pushed
the
add-load-wildcard-support
branch
from
February 23, 2021 13:46
5bc06e6
to
20f56cf
Compare
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
v-lopez
force-pushed
the
add-load-wildcard-support
branch
from
February 23, 2021 13:47
20f56cf
to
4212449
Compare
ivanpauno
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR @v-lopez !!
@v-lopez there are a few linter failures |
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
v-lopez
added a commit
to pal-robotics-forks/ros2cli
that referenced
this pull request
Feb 23, 2021
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
ivanpauno
pushed a commit
that referenced
this pull request
Mar 5, 2021
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #590 and #596