Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foxy backport Add rosparam verb load (#590) #596

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Foxy backport Add rosparam verb load (#590) #596

merged 3 commits into from
Mar 5, 2021

Conversation

v-lopez
Copy link
Contributor

@v-lopez v-lopez commented Feb 15, 2021

  • Add rosparam verb load

Signed-off-by: Victor Lopez victor.lopez@pal-robotics.com

  • Move load_parameter_file implementation to api, add test_verb_load

Signed-off-by: Victor Lopez victor.lopez@pal-robotics.com

  • Apply fixes for linter

Signed-off-by: Victor Lopez victor.lopez@pal-robotics.com

  • Remove TODO comment

Signed-off-by: Victor Lopez victor.lopez@pal-robotics.com

  • Fix linter errors

Signed-off-by: Audrow Nash audrow.nash@gmail.com

Co-authored-by: Audrow Nash audrow.nash@gmail.com

@v-lopez @audrow
Add rosparam verb load (ros2#590)
b080691 
* Add rosparam verb load

Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>

* Move load_parameter_file implementation to api, add test_verb_load

Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>

* Apply fixes for linter

Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>

* Remove TODO comment

Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>

* Fix linter errors

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>

Co-authored-by: Audrow Nash <audrow.nash@gmail.com>
@v-lopez v-lopez mentioned this pull request Feb 16, 2021
Merged
@audrow audrow self-assigned this Feb 19, 2021
audrow
audrow approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's wait to merge this in until another PR has been made addressing wildcard support (mentioned in #590), and we can merge them at the same time, in order.

@audrow
Copy link
Member

audrow commented Feb 19, 2021 •
edited
Loading

Here's CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@v-lopez v-lopez mentioned this pull request Feb 23, 2021
Merged
ivanpauno and others added 2 commits February 23, 2021 17:12
@ivanpauno
ros2 param dump/load should use fully qualified node names (ros2#600)
e91f9bd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@v-lopez
Add wildcard loading to ros2 param load (ros2#602)
12f8aef 
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
@v-lopez
Copy link
Contributor Author

v-lopez commented Feb 23, 2021 •
edited
Loading

@audrow I've updated the merge request with what was merged on master.

I've had to cherry-pick e91f9bd from @ivanpauno as well for consistency.

@jacobperron
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

I've retriggered CI with the CI_ROS_DISTRO variable set to foxy.

@bmagyar
Copy link

bmagyar commented Mar 5, 2021

Hey guys, can we please move ahead with this one as I can see it's been greenlighted by all parties involved?

This (and some PRs of us depending on it) would significantly improve some quality of life for ros2_control users 👍

@ivanpauno
Copy link
Member

ivanpauno commented Mar 5, 2021 •
edited
Loading

I think we probably should backport #600 and #602 together with this, @v-lopez what do you think?

@v-lopez
Copy link
Contributor Author

v-lopez commented Mar 5, 2021 •
edited
Loading

Agreed, would you like want me to create both backports PR?
Or just add them here?

@ivanpauno
Copy link
Member

Or just add them here?

I'm more inclined to this, as those PRs include related fixes.

@v-lopez
Copy link
Contributor Author

v-lopez commented Mar 5, 2021 •
edited
Loading

I think we already added them to this PR, right? On Feb 23rd.

@ivanpauno
Copy link
Member

I think we already added them to this PR, right? On Feb 23rd.

Oh sorry 😂.

Last CI looked good, windows job was yellow because of unrelated reasons.
Going in!!

@ivanpauno ivanpauno merged commit 094bcd9 into ros2:foxy Mar 5, 2021
@v-lopez
Copy link
Contributor Author

v-lopez commented Mar 9, 2021

Thanks! Do you have an ETA for the foxy 0.9.9 release?

@ivanpauno
Copy link
Member

Thanks! Do you have an ETA for the foxy 0.9.9 release?

IDK, last foxy sync was a week ago, so I guess next one will be in about a month.

@bmagyar bmagyar mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@audrow audrow audrow approved these changes

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-lopez @audrow @jacobperron @bmagyar @ivanpauno