Improve ros2 doctor on Windows #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Print an useful error message when failing to import rosdistro. * Print a clearer error message when failing to find either a loopback or no loopback interface on Windows. * Print "latest version" instead of "required version". * Print the corrent name of the python executable according to the platform. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
clalancette
reviewed
Apr 22, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
approved these changes
Apr 29, 2021
|
@ros-pull-request-builder retest this please |
|
CI:
|
|
@Mergifyio backport galactic |
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2021
Improve ros2 doctor on Windows: * Print a more useful error message when failing to load plugin * Print a clearer error message when failing to find either a loopback or no loopback interface on Windows. * Print "latest version" instead of "required version". * Print the corrent name of the python executable according to the platform. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit 3803d77)
|
Command
|
hidmic
pushed a commit
that referenced
this pull request
May 7, 2021
Improve ros2 doctor on Windows: * Print a more useful error message when failing to load plugin * Print a clearer error message when failing to find either a loopback or no loopback interface on Windows. * Print "latest version" instead of "required version". * Print the corrent name of the python executable according to the platform. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit 3803d77) Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
ros2 doctoron Windows was confusing.See the comment I wrote in the Galactic testing matric for more context.
rosdistropython package is not usually installed on Windows, so having a nicer message when not found is helpful.I updated "latest version" to "required version" because the warning shows that for that ros distribution there's a newer version of the package available in rosdistro, it's not really a required version.