add '--write' option to avoid an unintentional data loss. #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@clalancette @sloretz could you take a look? |
clalancette
reviewed
May 19, 2021
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@clalancette @audrow friendly ping. |
clalancette
requested changes
Jun 1, 2021
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
CI:
|
clalancette
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
This change looks good to me now, thanks! Can you please also add a note to https://github.com/ros2/ros2_documentation/blob/rolling/source/Releases/Release-Humble-Hawksbill.rst with this change? Thanks.
audrow
approved these changes
Jun 7, 2021
|
I jumped the gun and merged the documentation PR before this one. I'm going to go ahead and merge this one so the docs and the code are in sync. Thanks @fujitatomoya for picking this up! |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #625
Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com