Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle None Result #645 #646

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Handle None Result #645 #646

merged 1 commit into from
Jun 8, 2021

Conversation

iwmq
Copy link
Contributor

@iwmq iwmq commented Jun 2, 2021

Fix #645

@iwmq
Skip None Result
39af698 
Signed-off-by: jaywang <iwmq@qq.com>
@iwmq iwmq force-pushed the handle-none-result-in-param-list branch from 616ef14 to 39af698 Compare June 2, 2021 13:54
fujitatomoya
fujitatomoya approved these changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

audrow
audrow approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@audrow audrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI and a happy PR job.

@audrow
Copy link
Member

audrow commented Jun 7, 2021 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow
Copy link
Member

audrow commented Jun 7, 2021

@ros-pull-request-builder retest this please

@audrow audrow self-assigned this Jun 7, 2021
@audrow audrow added the bug Something isn't working label Jun 7, 2021
@audrow audrow merged commit a9def45 into ros2:master Jun 8, 2021
@audrow
Copy link
Member

audrow commented Jun 8, 2021

Thanks for the PR @iwmq!

@iwmq iwmq deleted the handle-none-result-in-param-list branch June 9, 2021 11:52
@llapx llapx mentioned this pull request Jun 14, 2022
Closed
@fujitatomoya
Copy link
Collaborator

@Mergifyio backport humble galactic foxy

mergify bot pushed a commit that referenced this pull request Jun 14, 2022
@iwmq @mergify
Skip None Result (#646)
11ce5b5 
Signed-off-by: jaywang <iwmq@qq.com>
(cherry picked from commit a9def45)
@mergify mergify bot mentioned this pull request Jun 14, 2022
Closed
mergify bot pushed a commit that referenced this pull request Jun 14, 2022
@iwmq @mergify
Skip None Result (#646)
ae7ec75 
Signed-off-by: jaywang <iwmq@qq.com>
(cherry picked from commit a9def45)
@mergify mergify bot mentioned this pull request Jun 14, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 14, 2022
@iwmq @mergify
Skip None Result (#646)
005d04d 
Signed-off-by: jaywang <iwmq@qq.com>
(cherry picked from commit a9def45)

# Conflicts:
#	ros2param/ros2param/verb/list.py
@mergify mergify bot mentioned this pull request Jun 14, 2022
Closed
@mergify
Copy link

mergify bot commented Jun 14, 2022

backport humble galactic foxy

✅ Backports have been created

fujitatomoya pushed a commit that referenced this pull request Jun 14, 2022
@iwmq @fujitatomoya
Skip None Result (#646)
ba9b973 
Signed-off-by: jaywang <iwmq@qq.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit a9def45)
fujitatomoya pushed a commit that referenced this pull request Jun 14, 2022
@iwmq @fujitatomoya
Skip None Result (#646)
b76ad34 
Signed-off-by: jaywang <iwmq@qq.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit a9def45)
fujitatomoya pushed a commit that referenced this pull request Jun 14, 2022
@iwmq @fujitatomoya
Skip None Result (#646)
8a03801 
Signed-off-by: Jay Wang <19398624+iwmq@users.noreply.github.com>
(cherry picked from commit a9def45)
clalancette pushed a commit that referenced this pull request Jun 30, 2022
@mergify @iwmq
Skip None Result (#646) (#723)
e312237 
Signed-off-by: Jay Wang <19398624+iwmq@users.noreply.github.com>
(cherry picked from commit a9def45)

Co-authored-by: Jay Wang <19398624+iwmq@users.noreply.github.com>
@po1 po1 mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@audrow audrow

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ros2 param list raises AttributeError
3 participants
@iwmq @audrow @fujitatomoya