Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set_message_fields from rosidl_runtime_py #761

Merged

Conversation

esteve
Copy link
Member

@esteve esteve commented Sep 12, 2022

This PR is pending ros2/rosidl_runtime_py#19

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the use-set_message_fields-from-rosidl_runtime_py branch from 69244e0 to 50f487f Compare September 14, 2022 10:33
@esteve esteve marked this pull request as ready for review September 14, 2022 10:49
@esteve
Copy link
Member Author

esteve commented Sep 14, 2022

@fujitatomoya @ivanpauno ros2/rosidl_runtime_py#19 has been merged and a new release of rosidl_runtime_py has been tagged, so this PR now ready for review

Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno
Copy link
Member

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member

I'm not sure what's going on with the Rpr job, but it's probably unrelated.

@ivanpauno
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

I'm not sure what's going on with the Rpr job, but it's probably unrelated.

We're currently in the middle of a large rebuild of Rolling, so that's what is causing it. It will probably take most of the day to complete.

@ivanpauno
Copy link
Member

@ros-pull-request-builder retest this please

@ivanpauno ivanpauno merged commit fd88d4e into ros2:rolling Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants