Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface type filters to ros2 interface package #765

Merged
merged 4 commits into from May 19, 2023
Merged

Add interface type filters to ros2 interface package #765

merged 4 commits into from May 19, 2023

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Sep 21, 2022

Seemed like it was missing.

@DLu
Copy link
Contributor Author

DLu commented Oct 13, 2022

Maybe @audrow could review?

@DLu DLu force-pushed the interface_type_filters branch 2 times, most recently from da368b4 to 8b3e95e Compare February 1, 2023 18:41
clalancette
clalancette requested changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more minor things to fix, then I think this will be ready for CI.

ros2interface/ros2interface/verb/package.py Show resolved Hide resolved
ros2interface/test/test_cli.py Outdated Show resolved Hide resolved
fujitatomoya
fujitatomoya reviewed Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with @clalancette comment addressed

DLu added 2 commits April 24, 2023 10:02
@DLu
Add interface type filters to ros2 interface package
1dd0071 
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@DLu
PR Feedback
f1260fb 
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@DLu DLu force-pushed the interface_type_filters branch 2 times, most recently from 08b86bd to 3cc24ec Compare April 24, 2023 14:10
@DLu
Flake, added tests, increased timeout
b597f4d 
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@DLu
Use the proper variables
009148c 
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@DLu DLu requested a review from clalancette May 19, 2023 18:19
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 4b2b2fd into ros2:rolling May 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DLu @clalancette @fujitatomoya @audrow