Fix printing of integer and double arrays. #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ros2param code, we get integer and double arrays as
literal Python arrays. When printing that out in ros2 param get,
they look something like:
Double values are: array('d', [1.4, 1.5])
But that isn't really what we want the user to see. So call .tolist()
on these before we print, so it looks like:
Double values are: [1.4, 1.5]
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ros2param code, we get integer and double arrays as literal Python arrays. When printing that out in ros2 param get, they look something like:
Double values are: array('d', [1.4, 1.5])
But that isn't really what we want the user to see. So call .tolist() on these before we print, so it looks like:
Double values are: [1.4, 1.5]
Signed-off-by: Chris Lalancette clalancette@openrobotics.org