Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2 topic {bw|delay|hz} don't support --no-daemon #869

Closed
scpeters opened this issue Nov 3, 2023 · 4 comments
Closed

ros2 topic {bw|delay|hz} don't support --no-daemon #869

scpeters opened this issue Nov 3, 2023 · 4 comments
Labels
question Further information is requested

Comments

@scpeters
Copy link

scpeters commented Nov 3, 2023

Feature request

Feature description

Support for the --no-daemon command-line argument was added to several of the ros2 topic verbs in #514, but it is not yet provided for the bw, delay or hz commands. It's also not available for pub, but I'm not sure if that matters.

Implementation considerations

@fujitatomoya
Copy link
Collaborator

I think that question is we need to NodeStrategy for these command options.

not yet provided for the bw, delay or hz commands. It's also not available for pub

I believe that all these sub-commands are used when we already know the topic is available via ros2 topic list or find, and then those sub-commands actually need to connect to the endpoint (not discovery configuration or graph). so i do not really think of the use case even for these...

any thoughts?

@fujitatomoya fujitatomoya added the question Further information is requested label Nov 4, 2023
@scpeters
Copy link
Author

scpeters commented Nov 4, 2023

ok, please close this issue if it is not valid. I don't really understand how the tools work on the inside; I just noticed an asymmetry in the CLI flags for some of the verbs and thought they could be made more consistent

@fujitatomoya
Copy link
Collaborator

@scpeters thanks for sharing your thoughts. i will close this for now, but there would be other opinion, and feel free to reopen!

@clalancette
Copy link
Contributor

Yeah, it turns out that we basically use the daemon for caching discovery information, so that commands like ros2 topic list return all of the topics in the system. In the case of commands where we don't need everything in the system, we don't use the daemon, and in that case we also don't need the --no-daemon command-line argument. I believe that applies to all of bw, delay, and hz; they will all wait around for a particular topic, and hence don't need to use the daemon at all.

All of that is to say that I don't think we need to do anything here. But thanks for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants