-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ros2 lifecycle #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes lgtm, I didn't try it on the console though, but I'm ok to merge it and cover that during testing (I assume you tested it anyways).
Flake8 failures addressed in 606e49c |
Retroactive summary for this feature: add ros2 lifecyclePurpose / Use Cases (Why implement this feature?)This was implemented to provide a way to control and introspect "lifecycle" ROS nodes from the command line. Design (How does it work?)It provides a new "command" to the Inputs / Outputs / API (How to use it?)The usage of the tool is documented in the help text with There is a "public" API which implements the actions the tool can take (used internally by the tool) but which is not currently documented, see: ros2cli/ros2lifecycle/ros2lifecycle/api/__init__.py Lines 1 to 169 in 211fc16
|
The example should not be using the underlying launch_ros ROS context or ROS node since it is an implementation detail. Instead, the example initailizes it's own context and ROS node. Fixes ros2#97. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Adding
ros2 lifecycle
with the following verbs:get
,list
,set
.Requires ros2/rosidl#281.