Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check rmw identifier #121

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Check rmw identifier #121

merged 3 commits into from
Jul 5, 2018

Conversation

mikaelarguedas
Copy link
Member

Potential fix for #120

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

without the patch:

Traceback (most recent call last):
  File "/opt/ros/bouncy/bin/ros2", line 11, in <module>
    load_entry_point('ros2cli==0.5.2', 'console_scripts', 'ros2')()
  File "/opt/ros/bouncy/lib/python3.6/site-packages/ros2cli/cli.py", line 69, in main
    rc = extension.main(parser=parser, args=args)
  File "/opt/ros/bouncy/lib/python3.6/site-packages/ros2node/command/node.py", line 39, in main
    return extension.main(args=args)
  File "/opt/ros/bouncy/lib/python3.6/site-packages/ros2node/verb/list.py", line 34, in main
    with NodeStrategy(args) as node:
  File "/opt/ros/bouncy/lib/python3.6/site-packages/ros2cli/node/strategy.py", line 29, in __init__
    spawn_daemon(args)
  File "/opt/ros/bouncy/lib/python3.6/site-packages/ros2cli/node/daemon.py", line 72, in spawn_daemon
    stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, **kwargs)
  File "/usr/lib/python3.6/subprocess.py", line 709, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.6/subprocess.py", line 1275, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType

with the patch:

# ros2 node list
Unable to get rmw_implementation_identifier, try specifying the implementation to use via the 'RMW_IMPLEMENTATION' environment variable

This allows to raise with an appropriate error message if the default rmw implementation is not installed on the system
@mikaelarguedas mikaelarguedas self-assigned this Jul 4, 2018
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 4, 2018
@mikaelarguedas mikaelarguedas merged commit e6d1e01 into master Jul 5, 2018
@mikaelarguedas mikaelarguedas deleted the check_rmw_identifier branch July 5, 2018 14:58
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 5, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* add Condition class and use in Action class

* add If and Unless Conditions which use Substitutions

* update actions to pass through condition arguments to Action base class

* fixup type annotations in ExecuteProcess action

* fixup architecture doc

* address flake8 failure that doesn't show locally for me
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
The example should not be using the underlying launch_ros ROS context or ROS node since it is an
implementation detail. Instead, the example initailizes it's own context and ROS node.

Fixes ros2#97.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants