Fix echo sometimes printing ..... #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
added
bug
12 tasks
dirk-thomas
reviewed
Aug 16, 2018
| # convert each key and value in the mapping | ||
| new_value = {} if isinstance(value, dict) else OrderedDict() | ||
| for k, v in value.items(): | ||
| new_value[_convert_value(k)] = _convert_value( | ||
| new_value[_convert_value(k, truncate_length=truncate_length)] = _convert_value( |
There was a problem hiding this comment.
I do see a major problem with this change: the keys in dictionary are now also being truncated which was not the case before. This will potentially lead to different keys being reduce to the same shortened key and therefore "loose" data.
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Support passing list of parameter file paths * Support pathlib Paths * WIP tests * Move tests to a separate package * Test parameters get resolved * Use EnvironmentVariable instead of ThisLaunchFileDir Doesn't work inside scripts * Env var needs to be specified in calling context not node itself * Add tests for invalid parameter arguments * Update other tests for consistency * Fixup * Update wording when not a file * typo
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* show error strings as part of the flake8 test Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * call new API which exposes the errors Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
If
truncate_lengthwas less than 3 then the...added to a list or sequence would be truncated. This fixes the issue by refactoring_convert_valueto only have one block of conditionals.I also changed
bytesfrom being displayed as"b'somebytestring'"to a string where every byte has been converted withchr.To test this PR manually
and
CI
connects to #129